[Asterisk-code-review] pbx_builtins: Corrects SayNumber warning (asterisk[16])

[George Joseph]

Attention is currently required from: Sean Bright, N A.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16083 )

Change subject: pbx_builtins: Corrects SayNumber warning
......................................................................


Patch Set 2: -Code-Review

(1 comment)

File main/pbx_builtins.c:

https://gerrit.asterisk.org/c/asterisk/+/16083/comment/c5eb0b47_cf483a97 
PS2, Line 1273: 	interrupt_string = pbx_builtin_getvar_helper(chan, "SAY_DTMF_INTERRUPT");
> The issue happens if the hangup is during ast_say_number, which is line 1300, after this point, so I'm not sure what checking here would accomplish?

If you want to leave it the way it is, that's fine.  I was just thinking that if the channel is hung up, you don't need to bother running any of the code in this function.  Would save a few CPU cycles since pbx_builtin_getvar_helper traverses all the channel variables to get interrupt_string.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16083
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ieea4a67301c6ea83bbc7690c1d4808d79a704594
Gerrit-Change-Number: 16083
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 10 Jun 2021 17:51:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210610/41e86744/attachment.html>