[Asterisk-code-review] pbx_builtins: Corrects SayNumber warning (asterisk[16])

George Joseph asteriskteam at digium.com
Fri Jun 11 09:19:11 CDT 2021


Attention is currently required from: Sean Bright, N A.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16083 )

Change subject: pbx_builtins: Corrects SayNumber warning
......................................................................


Patch Set 2: Code-Review+1

(3 comments)

File main/pbx_builtins.c:

https://gerrit.asterisk.org/c/asterisk/+/16083/comment/bab8c863_3c562d50 
PS2, Line 1273: 	interrupt_string = pbx_builtin_getvar_helper(chan, "SAY_DTMF_INTERRUPT");
> Yeah, the goal here is not the channel is not hanging up, it's to not output a confusing warning for […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16083/comment/e63f0fcc_f02f4ecf 
PS2, Line 1273: 	interrupt_string = pbx_builtin_getvar_helper(chan, "SAY_DTMF_INTERRUPT");
> Yeah, the goal here is not the channel is not hanging up, it's to not output a confusing warning for […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16083/comment/f9c1caea_53767e35 
PS2, Line 1273: 	interrupt_string = pbx_builtin_getvar_helper(chan, "SAY_DTMF_INTERRUPT");
> Yeah, the goal here is not the channel is not hanging up, it's to not output a confusing warning for […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16083
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ieea4a67301c6ea83bbc7690c1d4808d79a704594
Gerrit-Change-Number: 16083
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Fri, 11 Jun 2021 14:19:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210611/2f3d3146/attachment.html>


More information about the asterisk-code-review mailing list