[Asterisk-code-review] sig_analog: Changes to improve electromechanical signalling compatibi... (asterisk[master])

[Sarah Autumn]

Attention is currently required from: N A.
Sarah Autumn has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16151 )

Change subject: sig_analog: Changes to improve electromechanical signalling compatibility
......................................................................


Patch Set 2:

(1 comment)

File channels/sig_analog.c:

https://gerrit.asterisk.org/c/asterisk/+/16151/comment/00657a96_8104b6fa 
PS2, Line 1980: 				pbx_builtin_setvar_helper(chan, "ANI2", anibuf + 1);
> My only comment here is I wonder if a new ANI2 channel variable should be used, as opposed to settin […]
I'm not against changing it. But I don't think that Feature Group C CAMA-MF needs its very own ANI variable presented to the user as different from a Feature Group D ANI variable. Since a user won't be using Feature Group D or C on the same channel, there's no overlap. Also, from a user perspective, if you're running FGC and FGD channels, it might be annoying that you need to remember that they use different channel variables for what is essentially the same function--to store the ANI INFO disposition--and then have to account for that in your dialplan.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16151
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib7e27d987aee4ed9bc3663c57ef413e21b404256
Gerrit-Change-Number: 16151
Gerrit-PatchSet: 2
Gerrit-Owner: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Sat, 17 Jul 2021 15:50:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210717/e3b29c8a/attachment.html>