[Asterisk-code-review] sig_analog: Changes to improve electromechanical signalling compatibi... (asterisk[master])

[N A]

Attention is currently required from: Sarah Autumn.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16151 )

Change subject: sig_analog: Changes to improve electromechanical signalling compatibility
......................................................................


Patch Set 2:

(1 comment)

File channels/sig_analog.c:

https://gerrit.asterisk.org/c/asterisk/+/16151/comment/8a5573fe_3f57a0cb 
PS2, Line 1980: 				pbx_builtin_setvar_helper(chan, "ANI2", anibuf + 1);
> I'm not against changing it. […]
That's sort of what I was thinking too, in that case I think using the standard CALLERID(ANI2) variable would make the most sense, since IAX2 and SIP (and hopefully soon PJSIP) already natively parse into/from this variable, and the ANI2 variable shown here seems to have the same purpose as that, and then a user can call ${CALLERID(ANI2)} to get that. So instead of setting "ANI2" as a channel variable, I was thinking something like this: https://github.com/asterisk/asterisk/blob/b4347c486150653ec7ce1d129e8f9017c69344da/channels/sig_analog.c#L1999



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16151
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib7e27d987aee4ed9bc3663c57ef413e21b404256
Gerrit-Change-Number: 16151
Gerrit-PatchSet: 2
Gerrit-Owner: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Comment-Date: Sat, 17 Jul 2021 15:56:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210717/33af7e0d/attachment-0001.html>