[Asterisk-code-review] sig_analog: Changes to improve electromechanical signalling compatibi... (asterisk[master])

[N A]

Attention is currently required from: Sarah Autumn.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16151 )

Change subject: sig_analog: Changes to improve electromechanical signalling compatibility
......................................................................


Patch Set 2:

(1 comment)

File channels/sig_analog.c:

https://gerrit.asterisk.org/c/asterisk/+/16151/comment/0ce2a06a_84883c22 
PS2, Line 1980: 				pbx_builtin_setvar_helper(chan, "ANI2", anibuf + 1);
My only comment here is I wonder if a new ANI2 channel variable should be used, as opposed to setting the existing standard CALLERID(ANI2) or (deprecated?) CALLINGANI2 variables. featdmf in chan_dahdi already uses CALLERID(ANI2) for incoming calls. Is the new variable used for a different purpose?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16151
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib7e27d987aee4ed9bc3663c57ef413e21b404256
Gerrit-Change-Number: 16151
Gerrit-PatchSet: 2
Gerrit-Owner: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Comment-Date: Mon, 12 Jul 2021 12:05:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210712/c77bb6f6/attachment.html>