[Asterisk-code-review] res_rtp_asterisk: Automatically refresh stunaddr from DNS (asterisk[16])

[Sébastien Duthil]

Attention is currently required from: Joshua Colp.
Sébastien Duthil has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16168 )

Change subject: res_rtp_asterisk: Automatically refresh stunaddr from DNS
......................................................................


Patch Set 2:

(2 comments)

File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/16168/comment/314d78a5_1c63b6d4 
PS1, Line 3658: 	stunaddr_pointer = &stunaddr;
> If this is trying to ensure that the value of stunaddr doesn't change during usage, this won't work. […]
You're completely right, I changed it for a full copy.


https://gerrit.asterisk.org/c/asterisk/+/16168/comment/ac74f932_2274714d 
PS1, Line 3667: 		ast_sockaddr_to_sin(stunaddr_pointer, &stun_sin);
> Do we need to do this each time? It feels as though storing it in the format it would be used most c […]
I thought stunaddr could be a IPv6, hence needing the ast_sockaddr abstract type, but looking more closely, ast_stun_request() and stun_send() do not support other addresses families than IPv4, because they use sendto(..., sizeof(struct sockaddr_in)).

I will update the change to store stunaddr as sockaddr_in.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16168
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I7955a046293f913ba121bbd82153b04439e3465f
Gerrit-Change-Number: 16168
Gerrit-PatchSet: 2
Gerrit-Owner: Sébastien Duthil <sduthil at wazo.community>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Sat, 17 Jul 2021 03:33:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210716/ddca4449/attachment.html>