[Asterisk-code-review] res_rtp_asterisk: Automatically refresh stunaddr from DNS (asterisk[16])

[Joshua Colp]

Attention is currently required from: Sébastien Duthil.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16168 )

Change subject: res_rtp_asterisk: Automatically refresh stunaddr from DNS
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/16168/comment/d0833135_e9294b85 
PS1, Line 3667: 		ast_sockaddr_to_sin(stunaddr_pointer, &stun_sin);
> I thought stunaddr could be a IPv6, hence needing the ast_sockaddr abstract type, but looking more c […]
Correct, this STUN implementation is extremely old and predates IPv6 support so it is IPv4 only.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16168
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I7955a046293f913ba121bbd82153b04439e3465f
Gerrit-Change-Number: 16168
Gerrit-PatchSet: 2
Gerrit-Owner: Sébastien Duthil <sduthil at wazo.community>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sébastien Duthil <sduthil at wazo.community>
Gerrit-Comment-Date: Mon, 19 Jul 2021 11:57:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Sébastien Duthil <sduthil at wazo.community>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210719/f257fa29/attachment.html>