<p> Attention is currently required from: Joshua Colp. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/16168">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_rtp_asterisk.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16168/comment/314d78a5_1c63b6d4">Patch Set #1, Line 3658:</a> <code style="font-family:monospace,monospace">   stunaddr_pointer = &stunaddr;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">If this is trying to ensure that the value of stunaddr doesn't change during usage, this won't work. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">You're completely right, I changed it for a full copy.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16168/comment/ac74f932_2274714d">Patch Set #1, Line 3667:</a> <code style="font-family:monospace,monospace">               ast_sockaddr_to_sin(stunaddr_pointer, &stun_sin);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Do we need to do this each time? It feels as though storing it in the format it would be used most c […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I thought stunaddr could be a IPv6, hence needing the ast_sockaddr abstract type, but looking more closely, ast_stun_request() and stun_send() do not support other addresses families than IPv4, because they use sendto(..., sizeof(struct sockaddr_in)).</p><p style="white-space: pre-wrap; word-wrap: break-word;">I will update the change to store stunaddr as sockaddr_in.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16168">change 16168</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16168"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I7955a046293f913ba121bbd82153b04439e3465f </div>
<div style="display:none"> Gerrit-Change-Number: 16168 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Sébastien Duthil <sduthil@wazo.community> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 17 Jul 2021 03:33:12 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>