[Asterisk-code-review] res_statsd: replace meter type with counter (asterisk[16])

[Rijnhard Hessel]

Attention is currently required from: Joshua Colp.
Rijnhard Hessel has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16149 )

Change subject: res_statsd: replace meter type with counter
......................................................................


Patch Set 2:

(1 comment)

File res/res_chan_stats.c:

https://gerrit.asterisk.org/c/asterisk/+/16149/comment/6d69ef58_e0f3ae9a 
PS1, Line 76: 		ast_statsd_log(ast_str_buffer(metric), AST_STATSD_COUNTER, 1);
> We should avoid breaking existing functionality, for even a subset of users, if at all possible. […]
let me put it this way, neither the official statsd, datadog statsd nor telegraf, which are the 3 biggest server implementations support this, in fact it has quite an adverse affect on telegraf which screams blue murder about it, so its useless to the vast majority. 

In the general perspective I completely agree with you though, and the suggestion to append a suffix will prevent hard breakages. Unfortunately its pretty hard to keep a poorly supported metric, there really isn't another alternative.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16149
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I5fcb385983a1b88f03696ff30a26b55c546a1dd7
Gerrit-Change-Number: 16149
Gerrit-PatchSet: 2
Gerrit-Owner: Rijnhard Hessel <rijnhard at teleforge.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 08 Jul 2021 10:24:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Rijnhard Hessel <rijnhard at teleforge.co.za>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210708/5aa39779/attachment.html>