[Asterisk-code-review] res_statsd: replace meter type with counter (asterisk[16])

[Joshua Colp]

Attention is currently required from: Rijnhard Hessel.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16149 )

Change subject: res_statsd: replace meter type with counter
......................................................................


Patch Set 2:

(1 comment)

File res/res_chan_stats.c:

https://gerrit.asterisk.org/c/asterisk/+/16149/comment/c05ae9b5_a8b12f3b 
PS1, Line 76: 		ast_statsd_log(ast_str_buffer(metric), AST_STATSD_COUNTER, 1);
> let me put it this way, neither the official statsd, datadog statsd nor telegraf, which are the 3 bi […]
Could we not add an option which defaults to "yes" which sets whether it is supported or not, which would preserve existing behavior while allowing it be disabled and then in master it could be changed to default to off with an UPGRADE notice?

Other people more familiar with things may have an alternative suggestion too.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16149
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I5fcb385983a1b88f03696ff30a26b55c546a1dd7
Gerrit-Change-Number: 16149
Gerrit-PatchSet: 2
Gerrit-Owner: Rijnhard Hessel <rijnhard at teleforge.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Rijnhard Hessel <rijnhard at teleforge.co.za>
Gerrit-Comment-Date: Thu, 08 Jul 2021 10:45:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Rijnhard Hessel <rijnhard at teleforge.co.za>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210708/6318d92c/attachment.html>