<p> Attention is currently required from: Joshua Colp. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/16149">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_chan_stats.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16149/comment/6d69ef58_e0f3ae9a">Patch Set #1, Line 76:</a> <code style="font-family:monospace,monospace">                ast_statsd_log(ast_str_buffer(metric), AST_STATSD_COUNTER, 1);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">We should avoid breaking existing functionality, for even a subset of users, if at all possible. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">let me put it this way, neither the official statsd, datadog statsd nor telegraf, which are the 3 biggest server implementations support this, in fact it has quite an adverse affect on telegraf which screams blue murder about it, so its useless to the vast majority. </p><p style="white-space: pre-wrap; word-wrap: break-word;">In the general perspective I completely agree with you though, and the suggestion to append a suffix will prevent hard breakages. Unfortunately its pretty hard to keep a poorly supported metric, there really isn't another alternative.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16149">change 16149</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16149"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I5fcb385983a1b88f03696ff30a26b55c546a1dd7 </div>
<div style="display:none"> Gerrit-Change-Number: 16149 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Rijnhard Hessel <rijnhard@teleforge.co.za> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 08 Jul 2021 10:24:24 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Comment-In-Reply-To: Rijnhard Hessel <rijnhard@teleforge.co.za> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>