[Asterisk-code-review] app_if: Adds If, EndIf, and ExitIf applications (asterisk[master])

[N A]

Attention is currently required from: George Joseph, Richard Mudgett.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16121 )

Change subject: app_if: Adds If, EndIf, and ExitIf applications
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> I have not looked at this code but I am familiar with how the While/EndWhile applications operate. […]
Are you referring to dialplan parsing of the priorities here? I'm a bit confused, because the stuff between While and EndWhile definitely never executes if the While condition is false, it skips to the priority after EndWhile, and same thing with If/EndIf. I can see what you mean performance-wise maybe but just confused as it does do what's advertised from what I can tell.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16121
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3aa3bd35a5add82465c6ee9bd86b64601f0e1f49
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 06 Jul 2021 16:50:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210706/d6cd0a5d/attachment.html>