[Asterisk-code-review] app_if: Adds If, EndIf, and ExitIf applications (asterisk[master])

[Richard Mudgett]

Attention is currently required from: N A, George Joseph.
Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16121 )

Change subject: app_if: Adds If, EndIf, and ExitIf applications
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
I have not looked at this code but I am familiar with how the While/EndWhile applications operate.  

The main weak point with the While loop operation is that it really behaves like a C do/while loop.  The dialplan has to execute the loop at least once for it to work right.  If the While test is false the first time then it has no idea where to find the matching EndWhile location.  The While/EndWhile code remembers where it saw the While and the matching EndWhile the first time it goes through the loop.  The ExitWhile is similar to the While in that if the EndWhile has not been seen by an earlier loop iteration then it has no idea where to goto in the dialplan.

The If/ExitIf/EndIf code can only act like the first time through the While/EndWhile loop.  Which rather makes the If/EndIf concept useless.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16121
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3aa3bd35a5add82465c6ee9bd86b64601f0e1f49
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 06 Jul 2021 16:46:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210706/881183ae/attachment.html>