[Asterisk-code-review] app_if: Adds If, EndIf, and ExitIf applications (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Tue Jul 6 12:55:22 CDT 2021


Attention is currently required from: N A, George Joseph.
Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16121 )

Change subject: app_if: Adds If, EndIf, and ExitIf applications
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> Are you referring to dialplan parsing of the priorities here? I'm a bit confused, because the stuff  […]
I am talking about if the While test is false the *very* first time on the channel executing dialplan.  The EndWhile has not executed for the While to know where to goto in the dialplan.  If the While loop has executed once, the code has executed an EndWhile so the While knows where to goto in the dialplan when the test becomes false.

same = n,before-loop-dialplan
same = n,While(test-is-false-first-time)
same = n,loop-body-dialplan
same = n,EndWhile()
same = n,after-loop-dialplan

If EndWhile has never been executed after the loop-body-dialplan code on this channel then While does not know where EndWhile is in dialplan to goto after-loop-dialplan when the While test is false.

If the While test allows at least one loop iteration, the While code remembers the dialplan location where While is located.  When it executes the EndWhile application it remembers where that dialplan location is so any subsequent While or ExitWhile execution knows where to goto in the dialplan for the loop.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16121
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3aa3bd35a5add82465c6ee9bd86b64601f0e1f49
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 06 Jul 2021 17:55:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210706/32681ae8/attachment.html>


More information about the asterisk-code-review mailing list