[Asterisk-code-review] app_read: Allow reading # as a digit (asterisk[master])

[Sean Bright]

Attention is currently required from: N A, George Joseph.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16352 )

Change subject: app_read: Allow reading # as a digit
......................................................................


Patch Set 2:

(3 comments)

Patchset:

PS2: 
Update the topic of the review and your commit message to reference ASTERISK-18454


File include/asterisk/app.h:

https://gerrit.asterisk.org/c/asterisk/+/16352/comment/50d3f61b_9f37ef7c 
PS2, Line 155: char *terminator
terminator should be const char *


File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/16352/comment/ab615618_2acad904 
PS2, Line 252: 		res = ast_readstring(c, s, maxlen, to, fto, (terminator ? terminator : "#"));
The parens aren't necessary and you can just do:

 terminator ?: "#"

Or use:

 S_OR(terminator, "#")



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16352
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3033432adb9d296ad227e76b540b8b4a2417665b
Gerrit-Change-Number: 16352
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 25 Aug 2021 16:37:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210825/214e9fe1/attachment-0001.html>