<p> Attention is currently required from: N A, George Joseph. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/16352">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16352?tab=comments">Patch Set #2:</a> </p><p style="white-space: pre-wrap; word-wrap: break-word;">Update the topic of the review and your commit message to reference ASTERISK-18454</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File include/asterisk/app.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16352/comment/50d3f61b_9f37ef7c">Patch Set #2, Line 155:</a> <code style="font-family:monospace,monospace">char *terminator</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">terminator should be const char *</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File main/app.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/16352/comment/ab615618_2acad904">Patch Set #2, Line 252:</a> <code style="font-family:monospace,monospace">              res = ast_readstring(c, s, maxlen, to, fto, (terminator ? terminator : "#"));</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The parens aren't necessary and you can just do:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> terminator ?: "#"</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Or use:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> S_OR(terminator, "#")</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/16352">change 16352</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/16352"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3033432adb9d296ad227e76b540b8b4a2417665b </div>
<div style="display:none"> Gerrit-Change-Number: 16352 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-CC: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Attention: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 25 Aug 2021 16:37:01 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>