[Asterisk-code-review] app_read: Allow reading # as a digit (asterisk[master])

[N A]

Attention is currently required from: George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16352 )

Change subject: app_read: Allow reading # as a digit
......................................................................


Patch Set 2:

(2 comments)

File apps/app_read.c:

https://gerrit.asterisk.org/c/asterisk/+/16352/comment/665483ec_22395a58 
PS1, Line 78: 					<option name="p">
> You could have this take an argument to specify the terminators to use. […]
I thought a little bit about the idea before, but I like the idea - I've just changed the option from p to t to match up.


File main/app.c:

https://gerrit.asterisk.org/c/asterisk/+/16352/comment/40c33533_13009d20 
PS1, Line 196:  * \param terminator A string of characters that may be used as terminators to end input. Typically "#"
> This should be below the continuation line for "timeout".
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16352
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3033432adb9d296ad227e76b540b8b4a2417665b
Gerrit-Change-Number: 16352
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 25 Aug 2021 15:24:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210825/925851ed/attachment.html>