[Asterisk-code-review] res_tonedetect: Tone detection module (asterisk[master])

[N A]

Attention is currently required from: Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16234 )

Change subject: res_tonedetect: Tone detection module
......................................................................


Patch Set 6:

(2 comments)

File res/res_tonedetect.c:

https://gerrit.asterisk.org/c/asterisk/+/16234/comment/efa9106a_e5a61246 
PS4, Line 376: size = strlen(context) + strlen(exten) + strlen(pri) + 2;
> s/2/3
Done


https://gerrit.asterisk.org/c/asterisk/+/16234/comment/230a7275_c1a4ce32 
PS4, Line 619: 				frame = ast_frdup(frame); /* do not modify the original frame */
> Why the dupe? If the dupe is required then while you free the duplicated frame below it appears the  […]
Sorry, I got confused for a second. As you pointed out last week, ast_dsp_process frees the original frame and returns a new frame, so I updated this to reflect that. So I think I need to dupe in the audiohook, since we don't want to process the original frame there because we still need that, but when simply reading on the channel, we're the only consumer so I think we can process the original frame and free the result... correct me if that logic is wrong.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16234
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie38c395000f4fd4d04e942e8658e177f8f499b26
Gerrit-Change-Number: 16234
Gerrit-PatchSet: 6
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 20 Aug 2021 22:24:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210820/62f2aec7/attachment.html>