[Asterisk-code-review] res_tonedetect: Tone detection module (asterisk[master])

[Kevin Harwell]

Attention is currently required from: N A.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16234 )

Change subject: res_tonedetect: Tone detection module
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

File res/res_tonedetect.c:

https://gerrit.asterisk.org/c/asterisk/+/16234/comment/546820ee_489015b7 
PS6, Line 618: } else if (frame->frametype == AST_FRAME_VOICE) {
             : 				frame = ast_dsp_process(chan, dsp, frame);
             : 				if (frame->frametype == AST_FRAME_DTMF) {
             : 					char result = frame->subclass.integer;
             : 					ast_frfree(frame);
             : 					if (result == 'q') {
             : 						hits++;
             : 						ast_debug(1, "We just detected %s Hz (hit #%d)\n", args.freqs, hits);
             : 						if (hits >= times) {
             : 							pbx_builtin_setvar_helper(chan, "WAITFORTONESTATUS", "SUCCESS");
             : 							break;
             : 						}
             : 					}
             : 				} else {
             : 					ast_frfree(frame);
             : 				}
             : 			}
The if "frametype != voice" path is still leaking the frame.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16234
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie38c395000f4fd4d04e942e8658e177f8f499b26
Gerrit-Change-Number: 16234
Gerrit-PatchSet: 6
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 24 Aug 2021 16:44:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210824/6f383b71/attachment-0001.html>