[Asterisk-code-review] res_tonedetect: Tone detection module (asterisk[master])

[Kevin Harwell]

Attention is currently required from: N A.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16234 )

Change subject: res_tonedetect: Tone detection module
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

File res/res_tonedetect.c:

https://gerrit.asterisk.org/c/asterisk/+/16234/comment/2ea4e4d0_0063035e 
PS4, Line 376: size = strlen(context) + strlen(exten) + strlen(pri) + 2;
s/2/3


https://gerrit.asterisk.org/c/asterisk/+/16234/comment/2a2a1c22_d47eed43 
PS4, Line 619: 				frame = ast_frdup(frame); /* do not modify the original frame */
Why the dupe? If the dupe is required then while you free the duplicated frame below it appears the originally read frame is not freed, so a leak still exists.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16234
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie38c395000f4fd4d04e942e8658e177f8f499b26
Gerrit-Change-Number: 16234
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Fri, 20 Aug 2021 21:52:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210820/3cb39f7f/attachment.html>