[Asterisk-code-review] res_tonedetect: Tone detection module (asterisk[master])

[N A]

Attention is currently required from: Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16234 )

Change subject: res_tonedetect: Tone detection module
......................................................................


Patch Set 4:

(8 comments)

File res/res_tonedetect.c:

https://gerrit.asterisk.org/c/asterisk/+/16234/comment/dd64bf95_7f60149b 
PS3, Line 235: 	if (audiohook->status == AST_AUDIOHOOK_STATUS_DONE)
             : 		return 0;
             : 
             : 	/* Grab datastore which contains our gain information */
             : 	if (!(datastore = ast_channel_datastore_find(chan, &detect_datastore, NULL)))
             : 		return 0;
> Add braces to if blocks
Done


https://gerrit.asterisk.org/c/asterisk/+/16234/comment/c4432a8e_08d64999 
PS3, Line 244: 	if (!frame || frame->frametype != AST_FRAME_VOICE)
             : 		return 0;
             : 
             : 	if (!(direction == AST_AUDIOHOOK_DIRECTION_READ ? &di->rx : &di->tx))
             : 		return 0;
> Add braces to if block
Done


https://gerrit.asterisk.org/c/asterisk/+/16234/comment/0104622c_00e80141 
PS3, Line 372: 	size = sizeof(context) + sizeof(exten) + sizeof(pri) + 2;
> s/sizeof/strlen […]
Done


https://gerrit.asterisk.org/c/asterisk/+/16234/comment/15e3deb9_f423ac40 
PS3, Line 373: 	dest = ast_malloc(size + 1);
> Add a NULL check here.
Done


https://gerrit.asterisk.org/c/asterisk/+/16234/comment/28cec3a0_ad696e92 
PS3, Line 460: 			return 0;
> Unlock channel before returning
Done


https://gerrit.asterisk.org/c/asterisk/+/16234/comment/5186793d_d768f3b9 
PS3, Line 463: 			return 0;
> Unlock channel before returning
Done


https://gerrit.asterisk.org/c/asterisk/+/16234/comment/38971cfd_22558b4c 
PS3, Line 469: 			return -1;
> Free the datastore and unlock channel before returning
Done


https://gerrit.asterisk.org/c/asterisk/+/16234/comment/543e3b61_9ca9f521 
PS3, Line 618: 			}
> frame needs to be freed once done.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16234
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie38c395000f4fd4d04e942e8658e177f8f499b26
Gerrit-Change-Number: 16234
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 19 Aug 2021 20:26:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210819/5d4d92a6/attachment.html>