[Asterisk-code-review] media_cache: Don't lock when curl the remote file (asterisk[master])

Andre Barbosa asteriskteam at digium.com
Wed Aug 18 03:54:20 CDT 2021


Attention is currently required from: Joshua Colp, Andre Barbosa.
Hello Joshua Colp, Kevin Harwell, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/16233

to look at the new patch set (#4).

Change subject: media_cache: Don't lock when curl the remote file
......................................................................

media_cache: Don't lock when curl the remote file

When playing a remote sound file, which is not in cache, first we need to download
it with ast_bucket_file_retrieve.

This can take a while if the remote host is slow. The current CURL timeout is
180secs, so in extreme situations, it can take 3 minutes to return.

Because ast_media_cache_retrieve has a lock on all function, while we are waiting
for the delayed download, Asterisk is not able to play any more files, even the
files already cached locally.

ASTERISK-29544 #close

Change-Id: I8d4142b463ae4a1d4c41bff2bf63324821567408
---
M main/media_cache.c
1 file changed, 25 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/33/16233/4
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16233
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8d4142b463ae4a1d4c41bff2bf63324821567408
Gerrit-Change-Number: 16233
Gerrit-PatchSet: 4
Gerrit-Owner: Andre Barbosa <andre.emanuel.barbosa at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Andre Barbosa <andre.emanuel.barbosa at gmail.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210818/269093d2/attachment.html>


More information about the asterisk-code-review mailing list