[Asterisk-code-review] media_cache: Don't lock when curl the remote file (asterisk[master])

[Andre Barbosa]

Attention is currently required from: Joshua Colp, Kevin Harwell.
Andre Barbosa has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16233 )

Change subject: media_cache: Don't lock when curl the remote file
......................................................................


Patch Set 3:

(2 comments)

File main/media_cache.c:

https://gerrit.asterisk.org/c/asterisk/+/16233/comment/550ff3b6_1958f894 
PS3, Line 193: 	/* we unlock to curl the file */
> It's my understanding the 'bucket support' is a generic retrieval layer. […]
Added a more detail comment.


https://gerrit.asterisk.org/c/asterisk/+/16233/comment/813e8797_cc7d9f00 
PS3, Line 214: 		ao2_ref(bucket_file, -1);
             : 		ast_bucket_file_delete(bucket_file);
> Swap these two statements. You'll need to delete the file first, and then unref the object.
Fixed! thanks!



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16233
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8d4142b463ae4a1d4c41bff2bf63324821567408
Gerrit-Change-Number: 16233
Gerrit-PatchSet: 3
Gerrit-Owner: Andre Barbosa <andre.emanuel.barbosa at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 18 Aug 2021 10:09:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210818/eed0605f/attachment.html>