[Asterisk-code-review] media_cache: Don't lock when curl the remote file (asterisk[master])

[Kevin Harwell]

Attention is currently required from: Joshua Colp, Andre Barbosa.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16233 )

Change subject: media_cache: Don't lock when curl the remote file
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

File main/media_cache.c:

https://gerrit.asterisk.org/c/asterisk/+/16233/comment/658c51d1_90eef88f 
PS3, Line 193: 	/* we unlock to curl the file */
It's my understanding the 'bucket support' is a generic retrieval layer. As such 'curl' may not be the only backend. Remove mentioning of 'curl', and expand this comment a bit stating more as to why we want to unlock/unblock during the retrieval, i.e. could take a long time.


https://gerrit.asterisk.org/c/asterisk/+/16233/comment/aeef38b6_393b4d83 
PS3, Line 214: 		ao2_ref(bucket_file, -1);
             : 		ast_bucket_file_delete(bucket_file);
Swap these two statements. You'll need to delete the file first, and then unref the object.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16233
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8d4142b463ae4a1d4c41bff2bf63324821567408
Gerrit-Change-Number: 16233
Gerrit-PatchSet: 3
Gerrit-Owner: Andre Barbosa <andre.emanuel.barbosa at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Andre Barbosa <andre.emanuel.barbosa at gmail.com>
Gerrit-Comment-Date: Tue, 17 Aug 2021 22:39:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210817/a6fa3446/attachment.html>