[Asterisk-code-review] Mofified funcs/func_curl.c so that 404's are handled as a failure. (asterisk[master])

[Dovid Bender]

Dovid Bender has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14900 )

Change subject: Mofified funcs/func_curl.c so that 404's are handled as a failure.
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/14900/2/funcs/func_curl.c 
File funcs/func_curl.c:

https://gerrit.asterisk.org/c/asterisk/+/14900/2/funcs/func_curl.c@659 
PS2, Line 659: 	long http_code = 0;	
> Excess space at the end
Ack. This will be corrected.


https://gerrit.asterisk.org/c/asterisk/+/14900/2/funcs/func_curl.c@745 
PS2, Line 745: 	if (http_code == 404){
> This is a breaking behavior change. […]
For the errors perhaps we can have a configuration that would specify which setting with which errors are considered a failure? If that is sufficient where would the configuration be? asterisk.conf or somewhere else?

This fix was done for Asterisk Real time where there is no place to check for errors. Either it passed or it failed. If it passed then we don't move over to the next real time option if not then we do.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14900
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib10e14ce240e8ceb659da63ea11b1d91ce6b179a
Gerrit-Change-Number: 14900
Gerrit-PatchSet: 2
Gerrit-Owner: Dovid Bender <dovid at telecurve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Sun, 27 Sep 2020 13:13:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200927/9bfb2d04/attachment.html>