[Asterisk-code-review] Mofified funcs/func_curl.c so that 404's are handled as a failure. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Tue Sep 29 05:53:59 CDT 2020


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14900 )

Change subject: Mofified funcs/func_curl.c so that 404's are handled as a failure.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14900/2/funcs/func_curl.c 
File funcs/func_curl.c:

https://gerrit.asterisk.org/c/asterisk/+/14900/2/funcs/func_curl.c@745 
PS2, Line 745: 	if (http_code == 404){
> For the errors perhaps we can have a configuration that would specify which setting with which error […]
I'd ask for additional feedback from others, but personally I still prefer what I previously described of providing the ability in dialplan to inspect.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14900
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib10e14ce240e8ceb659da63ea11b1d91ce6b179a
Gerrit-Change-Number: 14900
Gerrit-PatchSet: 2
Gerrit-Owner: Dovid Bender <dovid at telecurve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 29 Sep 2020 10:53:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dovid Bender <dovid at telecurve.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200929/3978edd9/attachment-0001.html>


More information about the asterisk-code-review mailing list