[Asterisk-code-review] Mofified funcs/func_curl.c so that 404's are handled as a failure. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14900 )

Change subject: Mofified funcs/func_curl.c so that 404's are handled as a failure.
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/14900/2//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/14900/2//COMMIT_MSG@7 
PS2, Line 7: Mofified funcs/func_curl.c so that 404's are handled as a failure.
This needs to follow the wiki page[1] for commit messages.

[1] https://wiki.asterisk.org/wiki/display/AST/Commit+Messages


https://gerrit.asterisk.org/c/asterisk/+/14900/2/funcs/func_curl.c 
File funcs/func_curl.c:

https://gerrit.asterisk.org/c/asterisk/+/14900/2/funcs/func_curl.c@659 
PS2, Line 659: 	long http_code = 0;	
Excess space at the end


https://gerrit.asterisk.org/c/asterisk/+/14900/2/funcs/func_curl.c@745 
PS2, Line 745: 	if (http_code == 404){
This is a breaking behavior change. Such a behavior change should be optional for users so they aren't caught off guard. This also only applies to 404, I think there should be the ability to actually inspect the response code from the dialplan and take action based on it instead so that specific response code behavior is not hard coded.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14900
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib10e14ce240e8ceb659da63ea11b1d91ce6b179a
Gerrit-Change-Number: 14900
Gerrit-PatchSet: 2
Gerrit-Owner: Dovid Bender <dovid at telecurve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 14 Sep 2020 12:56:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200914/ad0d8169/attachment.html>