[Asterisk-code-review] app_queue: Fix leave-empty not recording a call as abandoned (asterisk[16])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14811 )

Change subject: app_queue: Fix leave-empty not recording a call as abandoned
......................................................................


Patch Set 2: Code-Review+2

> Patch Set 2:
> 
> Hi Kevin,
> 
> Please see ASTERISK-29043, i wrote about the issue in detail here:
> https://issues.asterisk.org/jira/browse/ASTERISK-29043
> 
> Basically there are two places that handle leave-empty, one in wait_our_turn() and the other in queue_exec().
> Before #ASTERISK-25665, the wait_our_turn() one would return and let queue_exec() handle it, which caused double EXITEMPTY messages in queue_log, and its what #ASTERISK-25665 tried to fix.
> #ASTERISK-25665 changed it so each place handles leave-empty independently, each writes EXITEMPTY to queue_log, but only one had record_abandoned, which is what this patch is fixing.
> I am using this patch successfully in production systems and its working good, the numbers are correct and there is exactly 1 QueueCallerAbandon event for every call that left because of empty queue.

Yeah it's fine. I was just mentioning a different way to solve this. I won't let it hold things up though.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14811
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I1a71b81df78adff59af587f1d8483cf57df430c7
Gerrit-Change-Number: 14811
Gerrit-PatchSet: 2
Gerrit-Owner: Kfir Itzhak <mastertheknife at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 01 Sep 2020 14:22:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200901/8f953347/attachment.html>