<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 2:</p><p style="white-space: pre-wrap; word-wrap: break-word;">Hi Kevin,</p><p style="white-space: pre-wrap; word-wrap: break-word;">Please see ASTERISK-29043, i wrote about the issue in detail here:<br>https://issues.asterisk.org/jira/browse/ASTERISK-29043</p><p style="white-space: pre-wrap; word-wrap: break-word;">Basically there are two places that handle leave-empty, one in wait_our_turn() and the other in queue_exec().<br>Before #ASTERISK-25665, the wait_our_turn() one would return and let queue_exec() handle it, which caused double EXITEMPTY messages in queue_log, and its what #ASTERISK-25665 tried to fix.<br>#ASTERISK-25665 changed it so each place handles leave-empty independently, each writes EXITEMPTY to queue_log, but only one had record_abandoned, which is what this patch is fixing.<br>I am using this patch successfully in production systems and its working good, the numbers are correct and there is exactly 1 QueueCallerAbandon event for every call that left because of empty queue.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Yeah it's fine. I was just mentioning a different way to solve this. I won't let it hold things up though.</p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4; color: #000000;">Code-Review +2</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14811">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14811">change 14811</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14811"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I1a71b81df78adff59af587f1d8483cf57df430c7 </div>
<div style="display:none"> Gerrit-Change-Number: 14811 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Kfir Itzhak <mastertheknife@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 01 Sep 2020 14:22:02 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>