[Asterisk-code-review] res_pjsip: Don't set endpoint to unavailable in all cases. (asterisk[16])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14056 )

Change subject: res_pjsip: Don't set endpoint to unavailable in all cases.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14056/1/res/res_pjsip/pjsip_options.c 
File res/res_pjsip/pjsip_options.c:

https://gerrit.asterisk.org/c/asterisk/+/14056/1/res/res_pjsip/pjsip_options.c@1984 
PS1, Line 1984: 	/*
              : 		 * Using LIKE doesn't seem to work very well with non-realtime so we
              : 		 * fetch everything right now and do a filter on our side.
              : 		 */
              : 		endpoints = ast_sorcery_retrieve_by_fields(ast_sip_get_sorcery(),
              : 			"endpoint", AST_RETRIEVE_FLAG_MULTIPLE | AST_RETRIEVE_FLAG_ALL, NULL);
              : 		if (endpoints) {
              : 			ao2_callback(endpoints, OBJ_NODATA, sip_options_synchronize_endpoint, aor);
              : 			ao2_ref(endpoints, -1);
              : 		}
This should synchronize only endpoints which have this newly added AOR, but instead all endpoints are synchronized. There is no 'filter on our side'. I think need to filter endpoints before calling sip_options_synchronize_endpoint.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14056
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I3ee00023be2393113cd4e056599f23f3499ef164
Gerrit-Change-Number: 14056
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Comment-Date: Fri, 27 Mar 2020 15:28:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200327/dc2e0a51/attachment.html>