[Asterisk-code-review] res_pjsip: Don't set endpoint to unavailable in all cases. (asterisk[16])

Alexei Gradinari asteriskteam at digium.com
Fri Mar 27 10:40:31 CDT 2020


Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14056 )

Change subject: res_pjsip: Don't set endpoint to unavailable in all cases.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14056/1/res/res_pjsip/pjsip_options.c 
File res/res_pjsip/pjsip_options.c:

https://gerrit.asterisk.org/c/asterisk/+/14056/1/res/res_pjsip/pjsip_options.c@1985 
PS1, Line 1985: Using LIKE doesn't seem to work very well with non-realtime
I think non-realtime should be fixed so that LIKE works in all cases.
For realtime, this is a very inefficient task to fetch everything if there are a lot of endpoints. The endpoint object has a lot of fields.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14056
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I3ee00023be2393113cd4e056599f23f3499ef164
Gerrit-Change-Number: 14056
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Comment-Date: Fri, 27 Mar 2020 15:40:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200327/5f717140/attachment.html>


More information about the asterisk-code-review mailing list