<p><a href="https://gerrit.asterisk.org/c/asterisk/+/14056">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14056/1/res/res_pjsip/pjsip_options.c">File res/res_pjsip/pjsip_options.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14056/1/res/res_pjsip/pjsip_options.c@1984">Patch Set #1, Line 1984:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">   /*<br>             * Using LIKE doesn't seem to work very well with non-realtime so we<br>               * fetch everything right now and do a filter on our side.<br>             */<br>           endpoints = ast_sorcery_retrieve_by_fields(ast_sip_get_sorcery(),<br>                     "endpoint", AST_RETRIEVE_FLAG_MULTIPLE | AST_RETRIEVE_FLAG_ALL, NULL);<br>              if (endpoints) {<br>                      ao2_callback(endpoints, OBJ_NODATA, sip_options_synchronize_endpoint, aor);<br>                   ao2_ref(endpoints, -1);<br>               }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This should synchronize only endpoints which have this newly added AOR, but instead all endpoints are synchronized. There is no 'filter on our side'. I think need to filter endpoints before calling sip_options_synchronize_endpoint.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14056">change 14056</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14056"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I3ee00023be2393113cd4e056599f23f3499ef164 </div>
<div style="display:none"> Gerrit-Change-Number: 14056 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-CC: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 27 Mar 2020 15:28:16 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>