[Asterisk-code-review] pjsip: replace 180 by 183 if SDP negotiation has completed (...asterisk[16])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11379 )

Change subject: pjsip: replace 180 by 183 if SDP negotiation has completed
......................................................................


Patch Set 1:

> (1 comment)

I don't know 'under what cases neg will not exist'.
I found this patch https://gerrit.asterisk.org/7585
May be George can answer.

But according to the state transition diagram of the SDP negotiator
at pjmedia/include/pjmedia/sdp_neg.h
the neg cannot transition from non-NULL to NULL.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11379
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I7450b751083ec30d68d6abffe922215a15ae5a73
Gerrit-Change-Number: 11379
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 15 May 2019 15:58:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190515/049ed158/attachment.html>