[Asterisk-code-review] pjsip: replace 180 by 183 if SDP negotiation has completed (...asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11379 )

Change subject: pjsip: replace 180 by 183 if SDP negotiation has completed
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/11379/1/channels/chan_pjsip.c 
File channels/chan_pjsip.c:

https://gerrit.asterisk.org/#/c/11379/1/channels/chan_pjsip.c@1597 
PS1, Line 1597: 				pjmedia_sdp_neg_get_state(channel->session->inv_session->neg) == PJMEDIA_SDP_NEG_STATE_DONE)) {
Have you confirmed under what cases neg will not exist? I ask because this is operating within the channel thread - and not the session thread - so another thread could be performing SDP negotiation at the same time.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11379
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I7450b751083ec30d68d6abffe922215a15ae5a73
Gerrit-Change-Number: 11379
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 15 May 2019 10:19:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190515/75f04a1e/attachment.html>