[Asterisk-code-review] pjsip: replace 180 by 183 if SDP negotiation has completed (...asterisk[16])

Joshua Colp asteriskteam at digium.com
Thu May 16 08:16:52 CDT 2019


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11379 )

Change subject: pjsip: replace 180 by 183 if SDP negotiation has completed
......................................................................


Patch Set 1: Code-Review+1

Looking at the channel locking and the invite session SDP negotiation and such, I don't believe it's possible for the SDP negotiator to change state while this occurring so it seems safe and fine. This should be cherry picked to the other branches.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11379
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I7450b751083ec30d68d6abffe922215a15ae5a73
Gerrit-Change-Number: 11379
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 16 May 2019 13:16:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190516/13db5629/attachment.html>


More information about the asterisk-code-review mailing list