[Asterisk-code-review] res pjsip registrar: blocked threads on reliable transport s... (asterisk[13])

[Joshua C. Colp]

Joshua C. Colp has posted comments on this change. ( https://gerrit.asterisk.org/11014 )

Change subject: res_pjsip_registrar: blocked threads on reliable transport shutdown take 3
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Minor comments.

https://gerrit.asterisk.org/#/c/11014/2/res/res_pjsip_registrar.c
File res/res_pjsip_registrar.c:

https://gerrit.asterisk.org/#/c/11014/2/res/res_pjsip_registrar.c@427
PS2, Line 427: 			ast_sip_transport_monitor_unregister_all(register_contact_transport_shutdown_cb,
I'd suggest adding a comment here describing what this does in practice, because at first glance it can seem as though it is incorrect due to the use of "unregister_all" in the underlying function name.


https://gerrit.asterisk.org/#/c/11014/2/res/res_pjsip_registrar.c@440
PS2, Line 440: 				reason = "error";
I think this should be extended slightly to give a better reason than "error" in the error case as it may scare users by just saying "error" and isn't useful to us



-- 
To view, visit https://gerrit.asterisk.org/11014
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b06f9026ed177d6adfd538317c784a42c1b17a
Gerrit-Change-Number: 11014
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 26 Feb 2019 11:31:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190226/d1ce1163/attachment.html>