[Asterisk-code-review] res pjsip registrar: blocked threads on reliable transport s... (asterisk[13])

Kevin Harwell asteriskteam at digium.com
Wed Feb 20 13:28:17 CST 2019


Hello Friendly Automation, George Joseph, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/11014

to look at the new patch set (#2).

Change subject: res_pjsip_registrar: blocked threads on reliable transport shutdown take 3
......................................................................

res_pjsip_registrar: blocked threads on reliable transport shutdown take 3

When a contact was removed by the registrar it did not always check to see if
the circumstances involved a monitored reliable transport. For instance, if the
'remove_existing' option was set to 'true' then when existing contacts were
removed due to 'max_contacts' being reached, those existing contacts being
removed did not unregister the transport monitor.

Also, it was possible to add more than one monitor on a reliable transport for
a given aor and contact.

This patch makes it so all contact removals done by the registrar also remove
any associated transport monitors if necessary. It also makes it so duplicate
monitors cannot be added for a given transport.

ASTERISK-28213

Change-Id: I94b06f9026ed177d6adfd538317c784a42c1b17a
---
M include/asterisk/res_pjsip.h
M res/res_pjsip/pjsip_transport_events.c
M res/res_pjsip_registrar.c
3 files changed, 129 insertions(+), 83 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/14/11014/2
-- 
To view, visit https://gerrit.asterisk.org/11014
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I94b06f9026ed177d6adfd538317c784a42c1b17a
Gerrit-Change-Number: 11014
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190220/680237bf/attachment-0001.html>


More information about the asterisk-code-review mailing list