<p style="white-space: pre-wrap; word-wrap: break-word;">Minor comments.</p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/11014">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11014/2/res/res_pjsip_registrar.c">File res/res_pjsip_registrar.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11014/2/res/res_pjsip_registrar.c@427">Patch Set #2, Line 427:</a> <code style="font-family:monospace,monospace">                        ast_sip_transport_monitor_unregister_all(register_contact_transport_shutdown_cb,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'd suggest adding a comment here describing what this does in practice, because at first glance it can seem as though it is incorrect due to the use of "unregister_all" in the underlying function name.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11014/2/res/res_pjsip_registrar.c@440">Patch Set #2, Line 440:</a> <code style="font-family:monospace,monospace">                                reason = "error";</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think this should be extended slightly to give a better reason than "error" in the error case as it may scare users by just saying "error" and isn't useful to us</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/11014">change 11014</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/11014"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I94b06f9026ed177d6adfd538317c784a42c1b17a </div>
<div style="display:none"> Gerrit-Change-Number: 11014 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua C. Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 26 Feb 2019 11:31:37 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>