[Asterisk-code-review] res pjsip registrar: blocked threads on reliable transport s... (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/11014 )

Change subject: res_pjsip_registrar: blocked threads on reliable transport shutdown take 3
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/11014/1/res/res_pjsip/pjsip_transport_events.c
File res/res_pjsip/pjsip_transport_events.c:

https://gerrit.asterisk.org/#/c/11014/1/res/res_pjsip/pjsip_transport_events.c@327
PS1, Line 327: 	monitored = ao2_find(transports, transport->obj_name, OBJ_SEARCH_KEY | OBJ_NOLOCK);
> So if you don't find an existing one do we not want to still add the new one?
No, if for some reason the transport is not found then there is no way to monitor a non-existent transport. And transports are only added/removed to the "active" list on connect/disconnect.



-- 
To view, visit https://gerrit.asterisk.org/11014
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b06f9026ed177d6adfd538317c784a42c1b17a
Gerrit-Change-Number: 11014
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 19:20:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190220/4b755959/attachment.html>