[Asterisk-code-review] res pjsip registrar: blocked threads on reliable transport s... (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/11014 )

Change subject: res_pjsip_registrar: blocked threads on reliable transport shutdown take 3
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/11014/1/include/asterisk/res_pjsip.h
File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/#/c/11014/1/include/asterisk/res_pjsip.h@3173
PS1, Line 3173:  *
Don't forget those \since's :)


https://gerrit.asterisk.org/#/c/11014/1/res/res_pjsip/pjsip_transport_events.c
File res/res_pjsip/pjsip_transport_events.c:

https://gerrit.asterisk.org/#/c/11014/1/res/res_pjsip/pjsip_transport_events.c@327
PS1, Line 327: 	monitored = ao2_find(transports, transport->obj_name, OBJ_SEARCH_KEY | OBJ_NOLOCK);
So if you don't find an existing one do we not want to still add the new one?



-- 
To view, visit https://gerrit.asterisk.org/11014
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b06f9026ed177d6adfd538317c784a42c1b17a
Gerrit-Change-Number: 11014
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 17:30:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190220/a07fa64f/attachment.html>