[Asterisk-code-review] res_pjsip: Add "send_cid_in_contact_user" option to endpoint (...asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12799 )

Change subject: res_pjsip: Add "send_cid_in_contact_user" option to endpoint
......................................................................


Patch Set 2: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/12799/2/configs/samples/pjsip.conf.sample 
File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/#/c/12799/2/configs/samples/pjsip.conf.sample@670 
PS2, Line 670: ;send_cid_in_contact_user=no ; Send the CallerID number in the user part of the Contact URI.
             :                 ; Some Public Service Access Points (PSAPs) require that the
             :                 ; caller id be sent in the user portion of the Contact header.
             :                 ; If set to yes, we send the callerid number regardless of any
             :                 ; privacy settings that might be in effect.
"Caller ID" is phrased 3 different ways in this paragraph: CallerID, caller id, and callerid.


https://gerrit.asterisk.org/#/c/12799/2/doc/CHANGES-staging/send_cid_in_contact_user.txt 
File doc/CHANGES-staging/send_cid_in_contact_user.txt:

https://gerrit.asterisk.org/#/c/12799/2/doc/CHANGES-staging/send_cid_in_contact_user.txt@5 
PS2, Line 5: caller id be sent in the user portion of the Contact header.
           : If set to yes, we send the callerid number regardless of any
More 'Caller ID' inconsistency


https://gerrit.asterisk.org/#/c/12799/2/res/res_pjsip.c 
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/12799/2/res/res_pjsip.c@456 
PS2, Line 456: 					<synopsis>Send the CallerID number in the user part of the Contact URI</synopsis>
             : 					<description><para>Some Public Service Access Points (PSAPs) require that the
             : 					caller id be sent in the user portion of the Contact header.
             : 					If set to yes, we send the callerid number regardless of any
More 'Caller ID' inconsistency


https://gerrit.asterisk.org/#/c/12799/2/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/12799/2/res/res_pjsip_session.c@1809 
PS2, Line 1809: 		pjsip_sip_uri *sip_uri = pjsip_uri_get_uri(session->inv_session->dlg->local.contact->uri);
Haven't looked that closely, but since I am adding other comments: do we need to make sure that this is a SIP/SIPS uri before we try to access the 'user' below?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12799
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ic2ca721f7bb5fab39c80907a33e16d4f94097f91
Gerrit-Change-Number: 12799
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 26 Aug 2019 19:39:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190826/4a0e4d9b/attachment.html>