<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/12799">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/12799/2/configs/samples/pjsip.conf.sample">File configs/samples/pjsip.conf.sample:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/12799/2/configs/samples/pjsip.conf.sample@670">Patch Set #2, Line 670:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">;send_cid_in_contact_user=no ; Send the CallerID number in the user part of the Contact URI.<br> ; Some Public Service Access Points (PSAPs) require that the<br> ; caller id be sent in the user portion of the Contact header.<br> ; If set to yes, we send the callerid number regardless of any<br> ; privacy settings that might be in effect.<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">"Caller ID" is phrased 3 different ways in this paragraph: CallerID, caller id, and callerid.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/12799/2/doc/CHANGES-staging/send_cid_in_contact_user.txt">File doc/CHANGES-staging/send_cid_in_contact_user.txt:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/12799/2/doc/CHANGES-staging/send_cid_in_contact_user.txt@5">Patch Set #2, Line 5:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">caller id be sent in the user portion of the Contact header.<br>If set to yes, we send the callerid number regardless of any<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">More 'Caller ID' inconsistency</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/12799/2/res/res_pjsip.c">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/12799/2/res/res_pjsip.c@456">Patch Set #2, Line 456:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> <synopsis>Send the CallerID number in the user part of the Contact URI</synopsis><br> <description><para>Some Public Service Access Points (PSAPs) require that the<br> caller id be sent in the user portion of the Contact header.<br> If set to yes, we send the callerid number regardless of any<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">More 'Caller ID' inconsistency</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/12799/2/res/res_pjsip_session.c">File res/res_pjsip_session.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/12799/2/res/res_pjsip_session.c@1809">Patch Set #2, Line 1809:</a> <code style="font-family:monospace,monospace"> pjsip_sip_uri *sip_uri = pjsip_uri_get_uri(session->inv_session->dlg->local.contact->uri);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Haven't looked that closely, but since I am adding other comments: do we need to make sure that this is a SIP/SIPS uri before we try to access the 'user' below?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/12799">change 12799</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/12799"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: Ic2ca721f7bb5fab39c80907a33e16d4f94097f91 </div>
<div style="display:none"> Gerrit-Change-Number: 12799 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 26 Aug 2019 19:39:19 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>