[Asterisk-code-review] res_pjsip: Add "send_cid_in_contact_user" option to endpoint (...asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12799 )

Change subject: res_pjsip: Add "send_cid_in_contact_user" option to endpoint
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/12799/2/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/12799/2/res/res_pjsip_session.c@1809 
PS2, Line 1809: 		pjsip_sip_uri *sip_uri = pjsip_uri_get_uri(session->inv_session->dlg->local.contact->uri);
> Haven't looked that closely, but since I am adding other comments: do we need to make sure that this is a SIP/SIPS uri before we try to access the 'user' below?

non sip/sips uris get caught and rejected in other places before reaching here.  Mot notably on the inbound side in pjsip_message_filter.c



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12799
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ic2ca721f7bb5fab39c80907a33e16d4f94097f91
Gerrit-Change-Number: 12799
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 26 Aug 2019 20:40:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190826/b4ea1306/attachment-0001.html>