[Asterisk-code-review] chan_unistim: Fix RTP port byte order for big-endian arch (...asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12747 )

Change subject: chan_unistim: Fix RTP port byte order for big-endian arch
......................................................................


Patch Set 1:

> I am current maintainer of chan_unistim and seems that no active developer currently know this code and protocol better then me. On the dissector level there is no difference between this fields, but current chan_unistim implementation do not use htons() to fill own RTP port bytes properly.

I understand the need for the change, I just didn't understand why we weren't also calling htons() on rtcpsin_port, but I see now that we do when we declare it.

I still think that using put_unaligned_uint16() would make the intention of this code more clear rather than manually bit-shifting.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12747
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I9a9ca7f26e31a67bbbceff12923baa10dfb8a3be
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 1
Gerrit-Owner: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Sun, 18 Aug 2019 15:28:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190818/38521fdb/attachment.html>