<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">I am current maintainer of chan_unistim and seems that no active developer currently know this code and protocol better then me. On the dissector level there is no difference between this fields, but current chan_unistim implementation do not use htons() to fill own RTP port bytes properly.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">I understand the need for the change, I just didn't understand why we weren't also calling htons() on rtcpsin_port, but I see now that we do when we declare it.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I still think that using put_unaligned_uint16() would make the intention of this code more clear rather than manually bit-shifting.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/12747">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/12747">change 12747</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/12747"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: I9a9ca7f26e31a67bbbceff12923baa10dfb8a3be </div>
<div style="display:none"> Gerrit-Change-Number: 12747 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Igor Goncharovsky <igor.goncharovsky@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Igor Goncharovsky <igor.goncharovsky@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 18 Aug 2019 15:28:16 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>