[Asterisk-code-review] chan_unistim: Fix RTP port byte order for big-endian arch (...asterisk[13])

[Igor Goncharovsky]

Igor Goncharovsky has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12747 )

Change subject: chan_unistim: Fix RTP port byte order for big-endian arch
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
> 
> (1 comment)
> 
> I know nothing about this protocol, but based on Wireshark's dissector, I see nothing different between the 4 ports being assigned in this block:
> 
> https://github.com/wireshark/wireshark/blob/master/plugins/epan/unistim/packet-unistim.c#L2272-L2284
> 
> So I feel like we should be changing all of them or none of them, but I will defer to someone with a better understanding of the protocol.

I am current maintainer of chan_unistim and seems that no active developer currently know this code and protocol better then me. On the dissector level there is no difference between this fields, but current chan_unistim implementation do not use htons() to fill own RTP port bytes properly.

Patched code successfully tested on big-endian and little-endian systems. Looking into wireshark ports for RTP/RTCP in/out after patch applied are correct.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12747
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I9a9ca7f26e31a67bbbceff12923baa10dfb8a3be
Gerrit-Change-Number: 12747
Gerrit-PatchSet: 1
Gerrit-Owner: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Sat, 17 Aug 2019 21:07:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190817/bc6bdc3f/attachment.html>