[Asterisk-code-review] app_queue: Set correct value by default for shared_lastcall (...asterisk[master])

[Friendly Automation]

Friendly Automation has submitted this change and it was merged. ( https://gerrit.asterisk.org/c/asterisk/+/11312 )

Change subject: app_queue: Set correct value by default for shared_lastcall
......................................................................

app_queue: Set correct value by default for shared_lastcall

There a long history here:

In commit dd1e62c095c has introduce by default shared_lastcall = true by
default but this now only happen is there not [general] directive in
queues.conf

After that, the commit 4b50e3f1ee84ae29da6d9eb3cfd9896a49d2394b fix the
sample file.

We'll need to keep the same setting if there a general or not section in
configuration file since the shared_lastcall is by a long time in
sample files as default value to 'no'.

Change-Id: Id44faec370136df8d57902b453ad4059ed21b94c
---
M apps/app_queue.c
M configs/samples/queues.conf.sample
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Kevin Harwell: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/apps/app_queue.c b/apps/app_queue.c
index 7cb26f0..ddb34c9 100644
--- a/apps/app_queue.c
+++ b/apps/app_queue.c
@@ -1478,7 +1478,7 @@
 static int montype_default = 0;
 
 /*! \brief queues.conf [general] option */
-static int shared_lastcall = 1;
+static int shared_lastcall = 0;
 
 /*! \brief queuesrules.conf [general] option */
 static int realtime_rules = 0;
diff --git a/configs/samples/queues.conf.sample b/configs/samples/queues.conf.sample
index 79b656b..073ec49 100644
--- a/configs/samples/queues.conf.sample
+++ b/configs/samples/queues.conf.sample
@@ -59,7 +59,7 @@
 ; respect the wrapuptime of another queue for a shared member.
 ; The default value is no.
 ;
-;shared_lastcall=no
+;shared_lastcall=yes
 ;
 ; Negative_penalty_invalid will treat members with a negative penalty as logged off
 ;

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11312
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Id44faec370136df8d57902b453ad4059ed21b94c
Gerrit-Change-Number: 11312
Gerrit-PatchSet: 1
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190430/ef721015/attachment.html>