[Asterisk-code-review] Remove Skip for wrapup_time test of app_queue: (...testsuite[master])

Rodrigo Ramirez Norambuena asteriskteam at digium.com
Mon Apr 29 16:39:06 CDT 2019


Rodrigo Ramirez Norambuena has uploaded this change for review. ( https://gerrit.asterisk.org/c/testsuite/+/11313


Change subject: Remove Skip for wrapup_time test of app_queue:
......................................................................

Remove Skip for wrapup_time test of app_queue:

Re add the wrapup_time for queues:
 - Fix run statement
 - Use shared_lastcall to 'no' setting [general] section

Change-Id: Iaa51026718dec3b503eb3570a18ba257d6a292ac
---
M tests/apps/queues/wrapup_time/configs/ast1/queues.conf
M tests/apps/queues/wrapup_time/run-test
M tests/apps/queues/wrapup_time/test-config.yaml
3 files changed, 7 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/13/11313/1

diff --git a/tests/apps/queues/wrapup_time/configs/ast1/queues.conf b/tests/apps/queues/wrapup_time/configs/ast1/queues.conf
index c8957e9..d607c84 100644
--- a/tests/apps/queues/wrapup_time/configs/ast1/queues.conf
+++ b/tests/apps/queues/wrapup_time/configs/ast1/queues.conf
@@ -1,3 +1,8 @@
+[general]
+; shared_lastcall = no
+; By default shared_lastcall is only there general
+; This patch fix that https://gerrit.asterisk.org/c/asterisk/+/11312
+
 [test_queue1]
 eventwhencalled=yes
 strategy=linear
diff --git a/tests/apps/queues/wrapup_time/run-test b/tests/apps/queues/wrapup_time/run-test
index 18da595..3634ecc 100755
--- a/tests/apps/queues/wrapup_time/run-test
+++ b/tests/apps/queues/wrapup_time/run-test
@@ -1,4 +1,3 @@
 #!/usr/bin/env bash
 set -e
-
-asttest -a /$AST_TEST_ROOT -s tests/queues/wrapup_time
+asttest -a /$AST_TEST_ROOT -s `dirname $0` $@
diff --git a/tests/apps/queues/wrapup_time/test-config.yaml b/tests/apps/queues/wrapup_time/test-config.yaml
index f5465b9..4aae653 100644
--- a/tests/apps/queues/wrapup_time/test-config.yaml
+++ b/tests/apps/queues/wrapup_time/test-config.yaml
@@ -1,6 +1,5 @@
 testinfo:
     summary:     'Test wrapuptime for queues'
-    skip: 'Skip while failures are debugged'
     description: |
         'This test runs two instances of Asterisk. One has shared_lastcall set in queues.conf
         and the other does not. Each instance of Asterisk contains two queues with the same two
@@ -11,4 +10,4 @@
     dependencies:
         - app: 'asttest'
     tags:
-        - queues
\ No newline at end of file
+        - queues

-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/11313
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: Iaa51026718dec3b503eb3570a18ba257d6a292ac
Gerrit-Change-Number: 11313
Gerrit-PatchSet: 1
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190429/e989a42a/attachment.html>


More information about the asterisk-code-review mailing list