<p>Friendly Automation <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11312">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Kevin Harwell: Looks good to me, approved
  Friendly Automation: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">app_queue: Set correct value by default for shared_lastcall<br><br>There a long history here:<br><br>In commit dd1e62c095c has introduce by default shared_lastcall = true by<br>default but this now only happen is there not [general] directive in<br>queues.conf<br><br>After that, the commit 4b50e3f1ee84ae29da6d9eb3cfd9896a49d2394b fix the<br>sample file.<br><br>We'll need to keep the same setting if there a general or not section in<br>configuration file since the shared_lastcall is by a long time in<br>sample files as default value to 'no'.<br><br>Change-Id: Id44faec370136df8d57902b453ad4059ed21b94c<br>---<br>M apps/app_queue.c<br>M configs/samples/queues.conf.sample<br>2 files changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/apps/app_queue.c b/apps/app_queue.c</span><br><span>index 7cb26f0..ddb34c9 100644</span><br><span>--- a/apps/app_queue.c</span><br><span>+++ b/apps/app_queue.c</span><br><span>@@ -1478,7 +1478,7 @@</span><br><span> static int montype_default = 0;</span><br><span> </span><br><span> /*! \brief queues.conf [general] option */</span><br><span style="color: hsl(0, 100%, 40%);">-static int shared_lastcall = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+static int shared_lastcall = 0;</span><br><span> </span><br><span> /*! \brief queuesrules.conf [general] option */</span><br><span> static int realtime_rules = 0;</span><br><span>diff --git a/configs/samples/queues.conf.sample b/configs/samples/queues.conf.sample</span><br><span>index 79b656b..073ec49 100644</span><br><span>--- a/configs/samples/queues.conf.sample</span><br><span>+++ b/configs/samples/queues.conf.sample</span><br><span>@@ -59,7 +59,7 @@</span><br><span> ; respect the wrapuptime of another queue for a shared member.</span><br><span> ; The default value is no.</span><br><span> ;</span><br><span style="color: hsl(0, 100%, 40%);">-;shared_lastcall=no</span><br><span style="color: hsl(120, 100%, 40%);">+;shared_lastcall=yes</span><br><span> ;</span><br><span> ; Negative_penalty_invalid will treat members with a negative penalty as logged off</span><br><span> ;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11312">change 11312</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11312"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id44faec370136df8d57902b453ad4059ed21b94c </div>
<div style="display:none"> Gerrit-Change-Number: 11312 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Rodrigo Ramirez Norambuena <a@rodrigoramirez.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>