[Asterisk-code-review] main/pbx.c: Fixed to call the ast_softhangup() (...asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11149 )

Change subject: main/pbx.c: Fixed to call the ast_softhangup()
......................................................................


Patch Set 8: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/11149/8/res/ari/resource_channels.c 
File res/ari/resource_channels.c:

https://gerrit.asterisk.org/#/c/11149/8/res/ari/resource_channels.c@1683 
PS8, Line 1683: 		/* channel is already hungup. */
This needs to go into more detail, and also be above the other pbx_exec.

Why this happens is because after pbx_exec returns the Stasis application has started the PBX on the channel and yielded control to it. This results in that thread having ownership, not this one.

What exactly happens when that occurs? Does the channel just immediately hang up like you mention?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11149
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6652359e42bb9fe3f2c44c03df4365c183baf73d
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 8
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Fri, 05 Apr 2019 11:25:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190405/6ddc124a/attachment-0001.html>